Increase text contrast for dark mode #308
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This improves readability at smaller font sizes.
This wraps the name portion of a method's signature in a `<b>` tag, including names in `:call-seq:` method signatures. In modern HTML, the `<b>` tag is "bring attention to element" rather than "bold". It is conventionally rendered with bold font weight, but it has no semantic meaning (unlike, for example, the `<strong>` tag). Co-authored-by: Shouichi Kamiya <[email protected]>
Monospace fonts are commonly rendered at a smaller point size than proportional fonts. In some cases, such as with the default font sizes of Firefox on Linux, the monospace font at 110% size is still smaller than the proportional font at 100% size. To ensure that method signatures appear at least as large as their subsequent descriptions, this commit changes their font size to `1rem`.
The distinction provided by the bold isn't necessary, and it added extra visual weight to the page.
jonathanhefner
force-pushed
the
dark-mode-increase-contrast
branch
from
735a226 to
e0f8e54
Compare
|
This is much easier to scan for me. 👍 |
p8
approved these changes
Sep 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes a handful of commits that improve readability when using dark mode.
Closes #307.