Allow template to return any kind of objects #51023
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix: rails#50930 While Action View is predominantly meant to render text, in sime case it's used to render more complex object. So we shouldn't assume `#_run` returns a buffer.
byroot
added a commit
that referenced
this pull request
Feb 9, 2024
Allow template to return any kind of objects
|
Backported to |
|
❤️ thank you! |
julik
pushed a commit
to cheddar-me/rails-twirp
that referenced
this pull request
Feb 13, 2024
Rails has shipped an incompatible change in ActiveView, that was reverted in later versions. See more here: rails/rails#51023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix: #50930
While Action View is predominantly meant to render text, in some case it's used to render more complex object.
So we shouldn't assume
#_runreturns a buffer.FYI: @kuwabarahiroshi, @julik