webpack fails to compile with ActionText

[willnet]

Steps to reproduce

rails new sampleapp
cd sampleapp
./bin/rails action_text:install
./bin/webpack 

Expected behavior

webpack compile without errors

Actual behavior

Hash: a8bf5b9bd28ddb3deacf
Version: webpack 4.32.2
Time: 3186ms
Built at: 2019/05/31 14:33:31
                                     Asset       Size       Chunks             Chunk Names
    js/application-498850090c9b38b11a80.js    870 KiB  application  [emitted]  application
js/application-498850090c9b38b11a80.js.map    771 KiB  application  [emitted]  application
                             manifest.json  364 bytes               [emitted]  
Entrypoint application = js/application-498850090c9b38b11a80.js js/application-498850090c9b38b11a80.js.map
[./app/javascript/channels sync recursive _channel\.js$] ./app/javascript/channels sync _channel\.js$ 160 bytes {application} [built]
[./app/javascript/channels/index.js] 487 bytes {application} [built]
[./app/javascript/packs/application.js] 799 bytes {application} [built]
[./node_modules/webpack/buildin/amd-options.js] (webpack)/buildin/amd-options.js 80 bytes {application} [built]
[./node_modules/webpack/buildin/global.js] (webpack)/buildin/global.js 1.01 KiB {application} [built]
[./node_modules/webpack/buildin/harmony-module.js] (webpack)/buildin/harmony-module.js 822 bytes {application} [built]
    + 302 hidden modules

ERROR in ./node_modules/@rails/actiontext/app/javascript/actiontext/attachment_upload.js 19:28-40
"export 'DirectUpload' was not found in '@rails/activestorage'
 @ ./node_modules/@rails/actiontext/app/javascript/actiontext/index.js
 @ ./app/javascript/packs/application.js

System configuration

Rails version:
6.0.0.rc1
Ruby version:
2.6.3

[abhaynikam]

I can reproduce this issue on Rails 6.0.0.rc1 but not on the master branch.

[y-yagi]

Maybe related to rails/webpacker#2109 (comment), rails/webpacker#2111.

[jakeNiemiec]

Related issue: #36278 (comment)

This should be fixed with @rails/[email protected].

[abhaynikam]

This should be fixed with @rails/[email protected]

@jakeNiemiec : I tried creating an app with Rails 6.0.0.rc1 and @rails/[email protected]. It still fails with the same error.

here is the gist of files you had asked in the comment -> https://gist.github.com/abhaynikam/62f9c4b32ebe81fb01052c59dca63ea4

[jakeNiemiec]

Did you run rails action_text:install? Also, can you post the exact error to the gist? I am unable to get an error with the same files.

[jernestosuarez]

Same error here with 6.0.0.rc1 and webpacker 4.0.6 after rails action_text:install in a fresh app.

[0x2C6]

Same here

[jakeNiemiec]

@jernestosuarez @0x2C6 @abhaynikam Can you tell me if changing line 61 in your babel.config.js file fixes it?

      [
        require('@babel/plugin-transform-runtime').default,
        {
          helpers: false,
          regenerator: true,
-         corejs: 3
+         corejs: false
        }
      ],

If not, can you post a gist like this: #36368 (comment) (👆4 comments up)

[abhaynikam]

@jakeNiemiec : With the change suggested in the babel.config.js in the above comment(#36368 (comment)).

Webpack compile worked for me. 👍

[jernestosuarez]

@jakeNiemiec : works for me too.

[atstockland]

corejs: false Fixed me up too

[jakeNiemiec]

Glad to hear it. PR to fix for everyone: rails/webpacker#2116

See rails/webpacker#2109 (comment) for further instructions.