-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feature: expose --help
from rails
#8
Merged
rafaelfranca
merged 4 commits into
rails:main
from
onshi:feature/expose_help_from_rails
Mar 28, 2024
Merged
feature: expose --help
from rails
#8
rafaelfranca
merged 4 commits into
rails:main
from
onshi:feature/expose_help_from_rails
Mar 28, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
onshi
force-pushed
the
feature/expose_help_from_rails
branch
3 times, most recently
from
March 27, 2024 02:10
9fb6637
to
a1402b8
Compare
onshi
force-pushed
the
feature/expose_help_from_rails
branch
2 times, most recently
from
March 27, 2024 02:29
71f58d1
to
3a3efb5
Compare
@@ -10,6 +10,15 @@ pub struct Cli { | |||
pub ruby_version: String, | |||
#[clap(long, short = 'r', default_value = "7.1.3")] | |||
pub rails_version: String, | |||
|
|||
#[command(subcommand)] | |||
pub command: Option<Commands>, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we write a test for this?
src/main.rs
Outdated
assert!(status.success()); | ||
match &cli.command { | ||
Some(Commands::RailsHelp {}) => { | ||
let mut child = DockerClient::get_help(&ruby_version, &rails_version) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Any reason to use subprocess here?
rafaelfranca
force-pushed
the
feature/expose_help_from_rails
branch
from
March 28, 2024 20:25
a3f7fe1
to
9e1a697
Compare
rafaelfranca
force-pushed
the
feature/expose_help_from_rails
branch
from
March 28, 2024 20:27
9e1a697
to
6b9fddd
Compare
thanks for wrapping it up 🙇🏻 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allows to expose
rails new --help
output as a subcommand forrails-new
closes #7
./target/debug/rails-new help
./target/debug/rails-new rails-help