Allow user to choose the HTML parser used #109
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
and minor cleanup in the README
Also provide helper methods: - `Rails::Dom::Testing.html_document` - `Rails::Dom::Testing.html_document_fragment` which will return a parser class based on the default or an optional injected `html_version:` kwarg. These methods will raise an exception if the configuration cannot be honored (e.g., the HTML5 parser isn't supported on the platform).
via an `html_version` kwarg: - assert_dom_equal and assert_dom_not_equal - assert_dom_encoded - assert_dom_email The remaining assertions all rely on `document_root_element` to return the DOM (meaning we'll have to make changes to Rails).
flavorjones
changed the title
4 tasks
paracycle
reviewed
Jul 7, 2023
flavorjones
force-pushed
the
flavorjones-dom-testing-html-version
branch
from
9de7532 to
2beaa6b
Compare
based on Rails' config.dom_testing_default_html_version
flavorjones
force-pushed
the
flavorjones-dom-testing-html-version
branch
from
2beaa6b to
144f8e5
Compare
|
I've fixed this PR to use |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR we:
Rails::Dom::Testing.default_html_version:html4but can be set to:html5html_version:, to override the default:assert_dom_equalassert_dom_not_equalassert_dom_emailassert_dom_encodedRails::Dom::Testing.html_documentand.html_document_fragmentdefault_html_versionand an optionalhtml_version:kwargRails::Dom::Testing.default_html_versionbased on the Rails config paramconfig.dom_testing_default_html_versionThis PR is a dependency of rails/rails#48682 which will:
config.dom_testing_default_html_versionhtml_documentandhtml_document_fragmenthelpers within Rails's own test helpers