Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Readme recommends broken version of jbuilder_cache_multi gem #399

Closed
markwpiper opened this issue Jun 1, 2017 · 4 comments
Closed

Readme recommends broken version of jbuilder_cache_multi gem #399

markwpiper opened this issue Jun 1, 2017 · 4 comments

Comments

@markwpiper
Copy link

README.md says "If you are rendering fragments for a collection of objects, have a look at jbuilder_cache_multi gem. It uses fetch_multi (>= Rails 4.1) to fetch multiple keys at once."

Unfortunately the current version of this gem has a critical bug (see yonahforst/jbuilder_cache_multi#17)

Please recommend using this gem only from github master until the bug fix has been released.
gem 'jbuilder_cache_multi', github: 'yonahforst/jbuilder_cache_multi', branch: 'master'

@dhh
Copy link
Member

dhh commented Jun 5, 2017

I trust that @yonahforst will soon be able to push out a fresh release to get this resolved 👍

@dhh dhh closed this as completed Jun 5, 2017
@yonahforst
Copy link
Contributor

just pushed

@dhh
Copy link
Member

dhh commented Jun 5, 2017 via email

@dhh
Copy link
Member

dhh commented Jun 5, 2017

BTW, I'd love to see multifetch collection handling added to Jbuilder. I've just pushed a 2.7.0 release that now requires Rails 4.2+, so it should be possible. I'd prefer if we didn't need a new method for it, though. Think that's possible? Something you're interested in working on? Thanks again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants