Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use non-subshell system variant in installer #208

Merged
merged 1 commit into from
Dec 1, 2023

Conversation

jonathanhefner
Copy link
Member

This prevents an error when the template path contains characters that should be escaped. For example, if the importmap-rails gem is installed in a directory that has whitespace characters in its path. Avoiding a subshell is also more performant.

This prevents an error when the template path contains characters that
should be escaped.  For example, if the `importmap-rails` gem is
installed in a directory that has whitespace characters in its path.
Avoiding a subshell is also more performant.
@jonathanhefner jonathanhefner merged commit 96c0e7c into rails:main Dec 1, 2023
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant