Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test installer #206

Merged
merged 1 commit into from
Nov 30, 2023
Merged

Test installer #206

merged 1 commit into from
Nov 30, 2023

Conversation

jonathanhefner
Copy link
Member

This commit adds test coverage for the installer Rake task and application template. The installer is run against a freshly generated Rails app using the version of Rails that is currently loaded. Thus the installer can be tested with different versions of Rails in CI.

This commit adds test coverage for the installer Rake task and
application template.  The installer is run against a freshly generated
Rails app using the version of Rails that is currently loaded.  Thus the
installer can be tested with different versions of Rails in CI.
@jonathanhefner jonathanhefner merged commit 6298cd4 into rails:main Nov 30, 2023
20 checks passed
zzak added a commit to zzak/stimulus-rails that referenced this pull request Jan 11, 2024
This commit adds test coverage for the installer Rake task and application template. The installer is run against a freshly generated Rails app using the version of Rails that is currently loaded. Thus the installer can be tested with different versions of Rails in CI.

Similar to rails/importmap-rails#206 for stimulus-rails

The motivation is to be able to move these tests from railties, see: rails/rails#49679

Co-authored-by: Jonathan Hefner <[email protected]>
zzak added a commit to zzak/stimulus-rails that referenced this pull request Jan 11, 2024
This commit adds test coverage for the installer Rake task and application template. The installer is run against a freshly generated Rails app using the version of Rails that is currently loaded. Thus the installer can be tested with different versions of Rails in CI.

Similar to rails/importmap-rails#206 for stimulus-rails

The motivation is to be able to move these tests from railties, see: rails/rails#49679

Co-authored-by: Jonathan Hefner <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant