Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Openssl 1.1.0 #347

Merged
merged 5 commits into from
Mar 12, 2017
Merged

Openssl 1.1.0 #347

merged 5 commits into from
Mar 12, 2017

Conversation

orgads
Copy link
Contributor

@orgads orgads commented Mar 2, 2017

See discussion on #310 and previous PR #344 by @metaskills.

@orgads orgads force-pushed the openssl-1.1.0 branch 5 times, most recently from 2885476 to 62032fd Compare March 2, 2017 22:56
@orgads
Copy link
Contributor Author

orgads commented Mar 2, 2017

Ok, this perl installation just doesn't work in this environment. Is there a way to grab another perl?

@metaskills
Copy link
Member

Love the DDL rename commit.

this perl installation just doesn't work in this environment

What does the OpenSSL team use on their Appveyor builds? This would help isolate if our C:\MinGW\msys\1.0\bin is still leaking issues.

@orgads
Copy link
Contributor Author

orgads commented Mar 3, 2017 •
edited
Loading

The problem is not AppVeyor, but the Ruby devkit. It is prepend to PATH, and users perl from mSYS1. This will be a problem with local builds as well.

I see 2 options:

  1. Download perl as part of openssl installing, and force using it (like I did here with C:\Perl, only that it will be in the build directory)
  2. Wait for rubyinstaller2, and drop support for devkit.

I prefer the first option.

The question is how do we fetch perl? Maybe from MSYS2? Do you have an idea?

@metaskills
Copy link
Member

I don't since this is not my speciality. cc @coderjoe

@orgads orgads force-pushed the openssl-1.1.0 branch 5 times, most recently from 172bb84 to faa3859 Compare March 4, 2017 21:21
@orgads
Copy link
Contributor Author

orgads commented Mar 4, 2017

Ok, this perl just doesn't work for openssl. I guess we have no choice but to install msys2.

@orgads orgads force-pushed the openssl-1.1.0 branch 4 times, most recently from 96c0c2c to 9718d93 Compare March 4, 2017 21:53
@orgads
Copy link
Contributor Author

orgads commented Mar 4, 2017

... Or use Git's! :)

@orgads orgads force-pushed the openssl-1.1.0 branch 3 times, most recently from 3183e8b to 5a1fcd1 Compare March 4, 2017 22:00
@orgads
Copy link
Contributor Author

orgads commented Mar 5, 2017

Finally a link problem! 64 but compiles. I'll look into it later.

@orgads
Use perl in Git installation for openssl
2b4c454 
OpenSSL requires Perl >= 5.10, while the Ruby devkit uses MSYS1 with
Perl 5.8.8.

To overcome this, prepend Git's usr/bin to the PATH. It has MSYS2 with a
recent version of perl.
@orgads
Copy link
Contributor Author

orgads commented Mar 5, 2017

Woohoo! :)

@metaskills
Copy link
Member

Amazing Work. Thanks! I'd like to hold off on this till #345 is done. I see some git conflicts, but that can be worked out.

In the meantime, I used this branch locally to build and publish v1.2.0.beta1 and pushed those gems to rubygems.org. I'm going to solicit others to test it out. Again, thanks!!!

@orgads
Copy link
Contributor Author

orgads commented Mar 6, 2017

My pleasure :)

@YvesR YvesR mentioned this pull request Mar 6, 2017
Closed
@metaskills
Copy link
Member

@coderjoe What do you think of merging this in and coping with the rebase in #345? I think it would be cool to get a 1.2.0 version out that is confirmed working better on Windows.

@coderjoe
Copy link
Contributor

coderjoe commented Mar 8, 2017

A hearty 👍. The rebase shouldn't be too much trouble at all. It sounds worth it.

@metaskills metaskills merged commit 3269dd3 into rails-sqlserver:master Mar 12, 2017
This was referenced Mar 12, 2017
Closed
Closed
Closed
Closed
Closed
@orgads orgads deleted the openssl-1.1.0 branch March 14, 2017 08:28
aharpervc pushed a commit to aharpervc/tiny_tds that referenced this pull request Apr 9, 2020
@orgads @aharpervc
OpenSSL v1.1.0. Fixes rails-sqlserver#347 rails-sqlserver#344 rails-s…
e279a7f 
…qlserver#310 rails-sqlserver#290 rails-sqlserver#349 rails-sqlserver#323 rails-sqlserver#330

* Use OpenSSL v1.1.0e & FreeTDS v1.00.27 for Windows builds.
* Adapt dll names to 1.1.0 scheme
 - libeay -> libcrypto
 - ssleay -> libssl
* Use perl in Git installation for openssl
* OpenSSL Requires Perl >= 5.10, while the Ruby devkit uses MSYS1 with Perl 5.8.8. To overcome this, prepend Git's usr/bin to the PATH. It has MSYS2 with a recent version of perl.
* MinGW: Fix inet_pton also for 32-bit
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@orgads @metaskills @coderjoe