Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

check if there is an open transaction #124

Merged
merged 1 commit into from
Dec 15, 2020
Merged

check if there is an open transaction #124

merged 1 commit into from
Dec 15, 2020

Conversation

rpbaltazar
Copy link
Contributor

Resolves #123

  • Before this commit, when creating a new tenant we would wrap the command around a transaction. This was leading to issues in some test scenarios where we have rspec's transactional fixtures enabled because all tests are then wrapped in a transaction by rspec.
  • After this, we check if there are any open transactions before trying to create the tenant. If yes, then we simply issue the create tenant command.

@rpbaltazar rpbaltazar merged commit 5812824 into development Dec 15, 2020
@rpbaltazar rpbaltazar deleted the 123-tenant-creation-in-transaction-makes-som branch December 15, 2020 08:33
@rpbaltazar rpbaltazar mentioned this pull request Dec 16, 2020
Merged
rpbaltazar added a commit that referenced this pull request Dec 16, 2020
@rpbaltazar
Merge pull request #126 from rails-on-services/development
8964442 
Prepare Release - 2.8.0

- Resolves #98 - Trying to generate an automatic changelog - #99
- Resolves #86 - Fixes seeding errors - #87
- Resolves #66 - Uses a transaction to create a tenant - #69
- Resolves #121 - Relaxes dependencies to allow rails 6.1 - #122
- Resolves #123 - When tests run in a transaction, new tenants in tests fail to create - #124
- Reverted unsafe initializer - #118
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Tenant creation in transaction makes some test cases fail
1 participant
@rpbaltazar