Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New version raises an error with ActiveSupport::LogSubscriber #128

Closed
nimarosa opened this issue Dec 16, 2020 · 5 comments · Fixed by #129
Closed

New version raises an error with ActiveSupport::LogSubscriber #128

nimarosa opened this issue Dec 16, 2020 · 5 comments · Fixed by #129

Comments

@nimarosa
Copy link

Hello, i just updated to the new version on rails 6.0.3 and i get a NameError for ActiveSupport::LogSubscriber.

I think it has to be with the recent changes to support version 6.1 like this one #125. Is the gem no longer offer compatibility with 6.0.3 apps? I plan to update but not yet because 6.1 is too recent and some gems get broken.
@rpbaltazar
Copy link
Contributor

It was not meant to break anything. Will look into it and fix it

@nickgal
Copy link
Contributor

nickgal commented Dec 16, 2020

I ran into this as well on 6.1.

As a temporary fix I added require 'active_record/log_subscriber' to my application.rb before the Bundler.require call.

rpbaltazar added a commit that referenced this issue Dec 17, 2020
@rpbaltazar
[#128] added config spec coverage. added missing require
fad3e73
@rpbaltazar rpbaltazar mentioned this issue Dec 17, 2020
Merged
rpbaltazar added a commit that referenced this issue Dec 17, 2020
@rpbaltazar
[#128] added log example to readme and config explanation
388d3df
rpbaltazar added a commit that referenced this issue Dec 17, 2020
@rpbaltazar
[#128] added note
86c7964
rpbaltazar added a commit that referenced this issue Dec 17, 2020
@rpbaltazar
[#128] exclude documentation support folder from gem
ba74c31
rpbaltazar added a commit that referenced this issue Dec 17, 2020
@rpbaltazar
[#128] added config spec coverage. added missing require
99ae4d7
rpbaltazar added a commit that referenced this issue Dec 17, 2020
@rpbaltazar
[#128] added log example to readme and config explanation
0f1c28c
rpbaltazar added a commit that referenced this issue Dec 17, 2020
@rpbaltazar
[#128] added note
3031dae
rpbaltazar added a commit that referenced this issue Dec 17, 2020
@rpbaltazar
[#128] exclude documentation support folder from gem
f714c8a
@rpbaltazar
Copy link
Contributor

rpbaltazar commented Dec 17, 2020 •
edited
Loading

@nicolasrsande / @nickgal can you test the development branch? I've currently an issue with the CI #130 which i'm trying to work out so until then I can't feasibly run the test suite.

@nimarosa
Copy link
Author

@rpbaltazar Sure, I will test it tomorrow morning and let you know the result.

@rpbaltazar rpbaltazar mentioned this issue Dec 17, 2020
Merged
@nimarosa
Copy link
Author

@rpbaltazar Confirmed development branch changes fix the error. All test passed. For me it's ready to merge.

rpbaltazar added a commit that referenced this issue Dec 18, 2020
@rpbaltazar
Merge pull request #131 from rails-on-services/development
2f62620 
Prepare Release - 2.8.1

**Implemented enhancements:**

**Fixed bugs:**

- New version raises an error with ActiveSupport::LogSubscriber [#128](#128)
- Weird logs when tenant fails to create [#127](<#127>)

**Closed issues:**

- Removed travis and slim configured circleci [#130](#130)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[#128] added config spec coverage. added missing require rails-on-services/apartment
3 participants
@nickgal @rpbaltazar @nimarosa