Define as_json instead of to_json #714
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
❤️ |
|
JRuby is pooping out for some reason, but I'm guessing the tests would pass? |
|
@locks some installation issue apparently, just restarted the failed job. |
carlosantoniodasilva
added a commit
that referenced
this pull request
Nov 4, 2014
Define as_json instead of to_json
|
All green 💚💛❤️💙💜 |
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As @chancancode mentioned in ohler55/oj#199 (comment), we should define as_json, no to_json, the latter should be called by ActiveSupport, no defined here directly
/cc @chancancode