-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix JRuby build on CI, with a suggestion from Travis CI support #2040
Conversation
@bf4, thanks for your PR! By analyzing the history of the files in this pull request, we identified @steveklabnik, @nadavshatz and @joshk to be potential reviewers. |
Great stuff, maybe worth updating/adding the JRuby version? |
All the JRuby failures on windows are of type:
|
@nadavshatz do you have a recommendation? |
@bf4 we are currently using What do you think? |
@nadavshatz pushed a commit. |
@bf4 looks good to me ! |
…s-api#2040) * Fix JRuby build on CI, with a suggestion from Travis CI support per hanami/helpers@13f30e2 per https://twitter.com/jodosha/status/823522145745731586
per
hanami/helpers@13f30e2
per https://twitter.com/jodosha/status/823522145745731586
and ref rails/rails#23453
Failures: