Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix JRuby build on CI, with a suggestion from Travis CI support #2040

Merged
merged 7 commits into from
Jan 26, 2017
Merged

Conversation

bf4
Copy link
Member

@bf4 bf4 commented Jan 24, 2017

per
hanami/helpers@13f30e2
per https://twitter.com/jodosha/status/823522145745731586

and ref rails/rails#23453

Failures:

Bundler could not find compatible versions for gem "json":
In snapshot (Gemfile.lock):
json (= 1.8.6) java
In Gemfile:
simplecov (> 0.11) java was resolved to 0.12.0, which depends on
json (< 3, >= 1.8) java
simplecov (
> 0.11) java was resolved to 0.12.0, which depends on
json (< 3, >= 1.8)

C:/Ruby21/lib/ruby/gems/2.1.0/gems/bundler-1.14.2/lib/bundler/resolver.rb:207:in rescue in start': Bundler could not find compatible versions for gem "nokogiri": (Bundler::VersionConflict) In snapshot (Gemfile.lock): nokogiri (= 1.7.0.1) x86-mingw32 In Gemfile: active_model_serializers x86-mingw32 was resolved to 0.10.4, which depends on actionpack (< 6, >= 4.1) x86-mingw32 was resolved to 4.2.7.1, which depends on rails-dom-testing (>= 1.0.5, ~> 1.0) was resolved to 1.0.8, which depends on nokogiri (~> 1.6) x86-mingw32 active_model_serializers x86-mingw32 was resolved to 0.10.4, which depends on actionpack (< 6, >= 4.1) x86-mingw32 was resolved to 4.2.7.1, which depends on rails-dom-testing (>= 1.0.5, ~> 1.0) was resolved to 1.0.8, which depends on nokogiri (~> 1.6) Running bundle update` will rebuild your snapshot from scratch, using only

@mention-bot
Copy link

@bf4, thanks for your PR! By analyzing the history of the files in this pull request, we identified @steveklabnik, @nadavshatz and @joshk to be potential reviewers.

@nadavshatz
Copy link
Contributor

Great stuff, maybe worth updating/adding the JRuby version?

@bf4
Copy link
Member Author

bf4 commented Jan 25, 2017

All the JRuby failures on windows are of type:

NoMethodError: undefined method `demodulize' for nil:NilClass
    C:/projects/active-model-serializers/lib/active_model_serializers/lookup_chain.rb:68:in `resource_class_name'
    C:/projects/active-model-serializers/lib/active_model_serializers/lookup_chain.rb:27:in `block in LookupChain'
    org/jruby/RubyProc.java:308:in `call'
    C:/projects/active-model-serializers/lib/active_model/serializer.rb:65:in `block in serializer_lookup_chain_for'
    org/jruby/RubyArray.java:1560:in `each'
    org/jruby/RubyEnumerable.java:836:in `flat_map'
    C:/projects/active-model-serializers/lib/active_model/serializer.rb:64:in `serializer_lookup_chain_for'
    C:/projects/active-model-serializers/lib/active_model/serializer.rb:87:in `block in get_serializer_for'
    C:/projects/active-model-serializers/vendor/bundle/jruby/2.2.0/gems/thread_safe-0.3.5-java/lib/thread_safe/cache.rb:68:in `block in fetch_or_store

@bf4
Copy link
Member Author

bf4 commented Jan 25, 2017

@nadavshatz do you have a recommendation?

@nadavshatz
Copy link
Contributor

@bf4 we are currently using 9.1.6.0. I think it would make sense to test against the latest stable or at least 9.0.*.* and 9.1.*.*.
If it's too much I would prefer 9.1.*.* as the latest minor level.

What do you think?

@bf4
Copy link
Member Author

bf4 commented Jan 26, 2017

@nadavshatz pushed a commit.

@nadavshatz
Copy link
Contributor

@bf4 looks good to me !

@bf4 bf4 merged commit 9ccdb15 into master Jan 26, 2017
@bf4 bf4 deleted the fix_ci branch January 26, 2017 19:52
GregPK pushed a commit to GregPK/active_model_serializers that referenced this pull request Apr 25, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants