-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update rendering.md #1799
Update rendering.md #1799
Conversation
Lgtm. 👍 |
@ScottKbka mind giving yourself credit in the misc section of the CHANGELOG? |
@bf4 Sure! Hoping to make more significant contributions down the road. Always happy to write docs though |
@@ -1,109 +1,99 @@ | |||
## 0.10.x | |||
# 0.10.x |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess it does look better even though I think there's never supposed to be >1 h1 on a page :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
however, mind making these changes to the changelog in a separate pr and explain some of the changes you're making?
Would be better for feedback since 0.10.1 is now released and there are merge conflicts
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will do! Honestly, I might have accidentally hit backspace on that line. I don't remember doing that!
@bf4 I'll have to do this later. Today's been a busy day. I'll fix the merge conflicts and let you know when it's done. 😸 |
@ScottKbka Hey, you interested in helping finish this one? |
@bf4 Where has this summer gone! Thanks for pinging me, I've been distracted here : ) It should all be fixed up now. |
LGTM 👍 |
Purpose
Documenting the
adapter
option in the rendering guide.Changes
Adding a description of the adapter option to the Guides.
Caveats
Related GitHub issues
None. PR made as per notes in guides.
Additional helpful information