Add Rails >= 5.0.beta3 JSON API params parsing #1747
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| data = { :_json => data } unless data.is_a?(Hash) | ||
| data.with_indifferent_access | ||
| end | ||
| ActiveModelSerializers::Jsonapi.install | ||
|
|
||
| # ref https://github.com/rails/rails/pull/21496 | ||
| ActionController::Renderers.add :jsonapi do |json, options| |
There was a problem hiding this comment.
line 72 is where travis is failing. media_type undefined
|
I'm handling this PR. For now, hold off on reviewing further. |
| # actionpack/lib/action_dispatch/http/mime_types.rb | ||
| Mime::Type.register MEDIA_TYPE, :jsonapi | ||
|
|
||
| mime_type = Mime::Type.lookup(MEDIA_TYPE) |
There was a problem hiding this comment.
This is equivalent to mime_type = Mime[MEDIA_TYPE].
remear
force-pushed
the
fix_jsonapi_mime_registration
branch
from
c1be9e8 to
ea06d3c
Compare
| def self.install | ||
| # actionpack/lib/action_dispatch/http/mime_types.rb | ||
| Mime::Type.register MEDIA_TYPE, :jsonapi | ||
| mime_type = Mime::Type.lookup(MEDIA_TYPE) |
There was a problem hiding this comment.
At the time it seemed like this didn't work the same between Rails 4.x and 5. I went tried again this morning it works just fine.
remear
force-pushed
the
fix_jsonapi_mime_registration
branch
2 times, most recently
from
bff3176 to
eec7750
Compare
remear
force-pushed
the
fix_jsonapi_mime_registration
branch
from
eec7750 to
bfd0bf4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
per cerebris/jsonapi-resources#642