Clarify AMS dependencies #1090
Merged
Clarify AMS dependencies #1090
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bf4
force-pushed
the
clarify_ams_dependencies
branch
from
e7b4059 to
0bb334a
Compare
|
👍 |
| gem 'actionpack' | ||
| gem 'actionview' | ||
| end | ||
| gem 'rails-controller-testing', github: 'rails/rails-controller-testing' |
There was a problem hiding this comment.
Yeah, this is a little complicated.. but cool bundler feature, eh?
|
Basically, I want to avoid installing any gems in test that aren't necessary to use AMS and might contribute to unexpected behavior. e.g. Right now AMS doesn't require ActionMailer or ActiveRecord, so why include it? |
bf4
force-pushed
the
clarify_ams_dependencies
branch
from
0bb334a to
e3d3d92
Compare
|
Nice @bf4, tks, merged |
|
😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.