Optimize room alias fetching #5892
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Don't download entire room state to get room aliases. This is especially important for the broadcast rooms which can have many thousand members.
ulope
force-pushed
the
fix/matrix/room-join-state-fetch
branch
from
e4e8d8b to
beca267
Compare
hackaugusto
approved these changes
Feb 21, 2020
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When joining a room we populate the aliases. This used to be done by downloading the entire rooms state only to then immediately discard any non-alias event.
This PR changes the behaviour so that only alias events are fetched form the server.
Unfortunately due to a limitation in the Matrix API it's not possible to query for all aliases of a room, only aliases for a given specific server can be fetched, see: matrix-org/synapse#6908
However, since in Raiden we always have server local aliases set for all broadcast rooms, this is sufficient.