Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fully support Infura and remove all warnings concerning its usage #5221

Merged
merged 7 commits into from
Nov 6, 2019

Conversation

LefterisJP
Copy link
Contributor

Fixes: #5217

Description

  • Fully supports Infura
  • Removes all warnings

PR review check list

Quality check list that cannot be automatically verified.

  • Safety
  • Code quality
    • Error conditions are handled
    • Exceptions are propagated to the correct parent greenlet
    • Exceptions are correctly classified as recoverable or unrecoverable
  • Compatibility
    • State changes are forward compatible
    • Transport messages are backwards and forward compatible
  • Commits
    • Have good messages
    • Squashed unecessary commits
  • If it's a bug fix:
    • Regression test for the bug
      • Properly covers the bug
      • If an integration test is used, it could not be written as a unit test
  • Documentation
    • A new CLI flag was introduced, is there documentation that explains usage?
  • Specs
    • If this is a protocol change, are the specs updated accordingly? If so, please link PR from the specs repo.
  • Is it a user facing feature/bug fix?
    • Changelog entry has been added

@codecov
Copy link

codecov bot commented Nov 5, 2019

Codecov Report

Merging #5221 into develop will decrease coverage by 0.01%.
The diff coverage is 22.72%.

Impacted file tree graph

@@            Coverage Diff             @@
##           develop   #5221      +/-   ##
==========================================
- Coverage    80.62%   80.6%   -0.02%     
==========================================
  Files          120     120              
  Lines        14856   14873      +17     
  Branches      2306    2308       +2     
==========================================
+ Hits         11977   11988      +11     
- Misses        2202    2205       +3     
- Partials       677     680       +3
Impacted Files Coverage Δ
raiden/ui/app.py 26.84% <100%> (+3.71%) ⬆️
raiden/network/rpc/client.py 72.42% <15%> (-3.14%) ⬇️
raiden/tasks.py 67.15% <0%> (-0.73%) ⬇️
raiden/network/transport/matrix/transport.py 79.29% <0%> (-0.46%) ⬇️
raiden/network/proxies/token_network.py 51.15% <0%> (+0.24%) ⬆️
raiden/transfer/node.py 94.7% <0%> (+0.55%) ⬆️
raiden/api/python.py 68.13% <0%> (+0.98%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c9cb0ff...33ecf5b. Read the comment docs.

Copy link
Contributor

@rakanalh rakanalh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. The PR has to be rebased because i changed some nonce related stuff for #4923

Copy link
Contributor

@konradkonrad konradkonrad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@LefterisJP LefterisJP merged commit 56c49a4 into raiden-network:develop Nov 6, 2019
@LefterisJP LefterisJP deleted the workon_5217 branch November 6, 2019 11:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fully support Infura
3 participants