Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1.8.21 is now the lowest geth supported #4983

Merged
merged 3 commits into from
Sep 25, 2019
Merged

1.8.21 is now the lowest geth supported #4983

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2c59a24
Set 1.8.21 to lowest supported geth version
LefterisJP Sep 25, 2019
743b82b
Adjust supported geth version unit tests
LefterisJP Sep 25, 2019
2fc6ccc
Mention lowest supported geth version change in the changelog
LefterisJP Sep 25, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions docs/changelog.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@
Changelog
=========

* :feature:`-` The lowest supported geth version is now 1.8.21.
* :feature:`4976` Geth users no longer need to activate the special txpool RPC api when starting their geth node.
* :feature:`4917` Added documentation on using Raiden for atomic swaps.
* :feature:`-` Added a new api endpoint ``/api/v1/version`` to query the raiden version via the Rest API.
Expand Down
2 changes: 1 addition & 1 deletion raiden/constants.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -163,7 +163,7 @@ class RoutingMode(Enum):

# Keep in sync with .circleci/config.yaml
HIGHEST_SUPPORTED_GETH_VERSION = "1.9.2"
LOWEST_SUPPORTED_GETH_VERSION = "1.7.2"
LOWEST_SUPPORTED_GETH_VERSION = "1.8.21"
# this is the last stable version as of this comment
HIGHEST_SUPPORTED_PARITY_VERSION = "2.5.5"
LOWEST_SUPPORTED_PARITY_VERSION = "1.7.6"
Expand Down
4 changes: 3 additions & 1 deletion raiden/tests/unit/test_cli.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,9 @@ def run_test_check_json_rpc_geth():

def test_check_json_rpc_geth():
# Pin the highest supported version for the test purposes
with patch("raiden.utils.ethereum_clients.HIGHEST_SUPPORTED_GETH_VERSION", new="1.9.2"):
with patch("raiden.utils.ethereum_clients.HIGHEST_SUPPORTED_GETH_VERSION", new="1.9.2"), patch(
"raiden.utils.ethereum_clients.LOWEST_SUPPORTED_GETH_VERSION", new="1.7.2"
LefterisJP marked this conversation as resolved.
Show resolved Hide resolved
):
run_test_check_json_rpc_geth()


Expand Down