-
Notifications
You must be signed in to change notification settings - Fork 377
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use coincurve instead of secp256k1-py #513
Comments
I got functions for keys, sign and address converted to use coincurve. |
@czepluch @hrishikeshio Thanks for the interest in coincurve! I've made the recovery workflow much easier in 4.2.0 by adding |
@ofek Thanks alot but now I am having a different issue. This function worked in earlier version. @czepluch Perhaps we should keep secp256k1.py for now and use coincurve later once it is more matured. |
Coincurve is stable! @hrishikeshio You seem to be using coincurve as a drop-in replacement for secp256k1-py. This will cause issues because the 2 don't share the same API. Coincurve has an API that is MUCH easier to use. I've documented it here: https://github.com/ofek/coincurve#readme. |
@hrishikeshio Just make a PR for pyethereum changin to coincurve aswell. |
Ah, excellent :) Thanks. |
Problem Definition
It seems that secp256k1-py is not being maintained anymore and that http://github.com/ofek/coincurve are maintaining a library instead.
Solution
Use http://github.com/ofek/coincurve instead of secp256k1-py
This should also remove the annoying warning from secp256k1-py when starting raiden.
The text was updated successfully, but these errors were encountered: