Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use coincurve instead of secp256k1-py #513

Closed
czepluch opened this issue Apr 11, 2017 · 8 comments
Closed

Use coincurve instead of secp256k1-py #513

czepluch opened this issue Apr 11, 2017 · 8 comments

Comments

@czepluch
Copy link
Contributor

czepluch commented Apr 11, 2017

Problem Definition

It seems that secp256k1-py is not being maintained anymore and that http://github.com/ofek/coincurve are maintaining a library instead.

Solution

Use http://github.com/ofek/coincurve instead of secp256k1-py
This should also remove the annoying warning from secp256k1-py when starting raiden.

@hrishikeshio
Copy link
Contributor

hrishikeshio commented Apr 16, 2017

I got functions for keys, sign and address converted to use coincurve.
Recover function does not seem to work work in coincurve as of latest version.
ofek/coincurve#1

@hrishikeshio
Copy link
Contributor

@ofek
Copy link
Contributor

ofek commented Apr 17, 2017

@czepluch @hrishikeshio Thanks for the interest in coincurve!

I've made the recovery workflow much easier in 4.2.0 by adding PublicKey.from_signature_and_message. Travis should be finished the deploy in less than an hour.

@hrishikeshio
Copy link
Contributor

@ofek Thanks alot but now I am having a different issue. This function worked in earlier version.
ofek/coincurve#2

@czepluch Perhaps we should keep secp256k1.py for now and use coincurve later once it is more matured.
Also ethereum.py is using secp256k1.py so it is not easy to remove dependency on secp256k1.py completely.

@ofek
Copy link
Contributor

ofek commented Apr 17, 2017

Coincurve is stable!

@hrishikeshio You seem to be using coincurve as a drop-in replacement for secp256k1-py. This will cause issues because the 2 don't share the same API. Coincurve has an API that is MUCH easier to use. I've documented it here: https://github.com/ofek/coincurve#readme.

@czepluch
Copy link
Contributor Author

@hrishikeshio Just make a PR for pyethereum changin to coincurve aswell.

@ofek
Copy link
Contributor

ofek commented Apr 17, 2017

@czepluch
Copy link
Contributor Author

Ah, excellent :) Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants