Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dependencies: bump typesafe-actions from 4.4.2 to 5.1.0 in /raiden-ts #474

Conversation

dependabot-preview[bot]
Copy link
Contributor

Bumps typesafe-actions from 4.4.2 to 5.1.0.

Commits

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
  • @dependabot badge me will comment on this PR with code to add a "Dependabot enabled" badge to your readme

Additionally, you can set the following in the .dependabot/config.yml file in this repo:

  • Update frequency
  • Out-of-range updates (receive only lockfile updates, if desired)
  • Security updates (receive only security updates, if desired)

@dependabot-preview dependabot-preview bot added the dependencies Pull requests that update a dependency file label Nov 3, 2019
@nephix
Copy link
Contributor

nephix commented Nov 5, 2019

I've checked the changes and the migration guide from 4.x to 5.x. The API changes are quite substantial and after trying to migrate to 5.x manually it seems like a lot of work.

My suggestion would be to migrate later when really necessary or upgrade the dependency but keep using the deprecated functions as explained in 1 of the migration guide:

import { deprecated } from "typesafe-actions"
const { createAction, createStandardAction, createCustomAction } = deprecated;

Overall I think staying at 4.x is the best option for now. CC @andrevmatos

@kelsos
Copy link
Contributor

kelsos commented Nov 15, 2019

Closing this PR, since this can't be merged there is no need to keep it open.

@kelsos kelsos closed this Nov 15, 2019
@dependabot-preview
Copy link
Contributor Author

OK, I won't notify you again about this release, but will get in touch when a new version is available.

If you change your mind, just re-open this PR and I'll resolve any conflicts on it.

@dependabot-preview dependabot-preview bot deleted the dependabot/npm_and_yarn/raiden-ts/typesafe-actions-5.1.0 branch November 15, 2019 10:07
@andrevmatos
Copy link
Contributor

Hmm, 5x seems to change too much, and I don't like the new interface. An alternative will be tracked by #591

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants