Fix revealTimeout on testnets #3118
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrevmatos
added
sdk 🖥
infrastructure 🚧
When fetching contract's settleTimeout, if revealTimeout is too large, we set it explicitly to a sane default (settleTimeout / 2), instead of leaving it there and failing transfer's requests until the user pass a suitable config.revealTimeout. Also, for that, we relax a little the transfer `expiration` constraint to `<settleTimeout`, so half of that will still work with expiryFactor=2
andrevmatos
force-pushed
the
fix/reveal_timeout_testnets
branch
from
cdf3f66
to
4568bf2
Compare
Codecov Report
@@ Coverage Diff @@
## master #3118 +/- ##
==========================================
+ Coverage 93.92% 93.94% +0.01%
==========================================
Files 213 213
Lines 7404 7411 +7
Branches 1244 1247 +3
==========================================
+ Hits 6954 6962 +8
+ Misses 416 415 -1
Partials 34 34
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
netcriptus
approved these changes
May 5, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #
Short description
This fixes a small issue identified on Arbitrum release (v3) on testnets (e.g.
arbitrum-rinkeby), wheresettleTimeoutin deployed contracts (180 seconds) is smaller than defaultrevealTimeout(600 seconds), making every transfer fail withexpires too soonerror.It also includes some simplification of conditionals in circleCI config, preparing for next [patch] release.
Definition of Done
Steps to manually test the change (dApp)