Arbitrum: chose matrix server from PFS #3069
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also, allow it to not only emit first best PFS, but instead prefer to emit all of them sorted, so caller can take `first` only if desired. This is intended in order to use this functions in other places of the code, like the matrix server choice in transport.
When matrixServer isn't set, we are in `auto` mode. Previously, we'd fetch the list from `matrixServerLookup`, but is easy to have this list mismatched with current network/deployment. This change prefers the same matrixServer from the PFSs, scanning first `config.additionalServices` and then services fetched from ServicesRegistry, which are expected to always be compatible with current deployment.
andrevmatos
added
enhancement
andrevmatos
changed the title
andrevmatos
force-pushed
the
matrix_server
branch
from
8989eff
to
03fcfe6
Compare
andrevmatos
force-pushed
the
matrix_server
branch
from
03fcfe6
to
b0650bc
Compare
weilbith
approved these changes
Mar 7, 2022
| mergeMap(({ pfsMode, additionalServices }) => { | ||
| if (pfsByAction) return of(pfsByAction); | ||
| else if (pfsMode === PfsMode.onlyAdditional) { | ||
| let firstError: Error; |
There was a problem hiding this comment.
Thanks for using full variable names without abbreviations. 🤗
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #
Short description
This is an enhancement to some situations seen while testing with Arbitrum. When not explicitly specified (e.g. through cli's
--matrix-servercommand line parameter), transport onautomode will download the list of servers from RSB's github (this list for testnets), and there's a high probability of those servers being incompatible with the current network (this is the case with arbitrum-rinkeby test PFS, which runs with its own matrix server).The motivation of this change is that PFSs are either passed explicitly or picked from the chosen contracts (through
ServicesRegistry), and therefore should always have a compatible matrix server, exposed in/api/v1/infoendpoint. Therefore, preferring the server from the PFS will mostly ensure it's compatible with the current network and PFS, and only as a fallback we download the list from thematrixServerLookupURL.Tests included.
This doesn't work only for Arbitrum, could work also for
master, but since this touches test code which was already changed onarbitrum(#3034), it was easier to target that base, and most new features are already going to it anyway.Definition of Done
Steps to manually test the change (dApp)