Feature/dapp adapt to arbitrum #3056
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The former is a cached getter function to fetch the timestamp (in millis) for a specific blockNumber, and the later is a cold cached (shareReplay'd) observable to fetch the contract's constant settleTimeout
fetches from Raiden.settleTimeout getter
In the past, channels had a settle timeout property. It was also possible to configure the SDK with a settle timeout value for new channels. This has changed with the latest version of the contracts and SDK. The settle timeout has moved from individual channels to the token network itself. In result channel data structure have no more this data field and the SDK doesn't accept this configuration option anymore. There is also a visual effect of this change. So far, if a channel got closed, the button to settle the channel was showing a countdown until it becomes possible. But not only was the settle timeout moved, it also changed its meaning from a block number based value to an actual time value in seconds. The issue is that this value can very from a few seconds to multiple days. In result is is not easy to maintain a countdown on the settle button. Also because the rendering of the Vue component would need to be force updated by an interval as it is now purely time based. To maintain the raw functionality for the moment, the button just remains disabled until the channel is settlable. This might improve in future again.
In the past, a planned UDC withdrawal had the property of a target `withdrawBlock` from which it is possible to withdraw the tokens. This has changed to a timestamp value (in Unix format) called `withdrawableAfter`. Due to this change, a couple of renaming where necessary. Furthermore this also has visual effects. On the view to the user deposit contract, if there was a planned withdraw pending (not yet withdrawable) it was showing a countdown for the blocks remaining. As this is not the case anymore, it has been changed to display the target date. Once this date has passed, the UI changes as usual and displays the user that the plan is now ready. There was also a tiny change in the translations, not only according block to time change. Also a special unicode character got replaced with a simple ASCII one, as the former one was not rendered properly for some users, depending on their system font.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for submitting this pull request :)
Fixes #3051 and #3053
Short description
I tackled both issues together, because only one of them would cause issues in the CI pipeline. Due to the underlying breaking changes of the SDK the dApp does not build properly without both changes together. As both issues are small enough, this should be fine.
Targets the
arbitrumbranch with the changes of the SDK.Definition of Done
Steps to manually test the change (dApp)
settlebut is disabled and no block countdown