Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

contracts: update to v0.40.0 #3012

Merged
merged 2 commits into from
Dec 17, 2021
Merged

contracts: update to v0.40.0 #3012

merged 2 commits into from
Dec 17, 2021

Conversation

andrevmatos
Copy link
Contributor

@andrevmatos andrevmatos commented Dec 14, 2021

Short description
Update contracts to v0.40.0 and e2e images with PC 3.0.0rc9

Definition of Done

  • Steps to manually test the change have been documented
  • Acceptance criteria are met
  • Change has been manually tested by the reviewer (dApp)

Steps to manually test the change (dApp)

@andrevmatos andrevmatos added the dependencies Pull requests that update a dependency file label Dec 14, 2021
@andrevmatos andrevmatos self-assigned this Dec 14, 2021
@codecov
Copy link

codecov bot commented Dec 14, 2021

Codecov Report

Merging #3012 (ce1eb55) into master (b5fd630) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3012   +/-   ##
=======================================
  Coverage   93.02%   93.02%           
=======================================
  Files         208      208           
  Lines        8436     8436           
  Branches     1346     1346           
=======================================
  Hits         7848     7848           
  Misses        481      481           
  Partials      107      107           
Flag Coverage Δ
dapp 87.89% <ø> (ø)
dapp.unit 87.89% <ø> (ø)
sdk 95.77% <ø> (ø)
sdk.e2e 72.66% <ø> (-0.17%) ⬇️
sdk.integration 80.27% <ø> (ø)
sdk.unit 49.39% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b5fd630...ce1eb55. Read the comment docs.

@palango
Copy link
Contributor

palango commented Dec 15, 2021

Any ideas why the e2e tests fail?

@andrevmatos
Copy link
Contributor Author

@palango no, but I'm working on it

@andrevmatos
Copy link
Contributor Author

@paul should be ready now.. the issue was a geth renamed param

@andrevmatos andrevmatos merged commit ee429e4 into master Dec 17, 2021
@andrevmatos andrevmatos deleted the update/contracts branch December 17, 2021 11:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants