remove latest$.gasPrice, epics and actions, calculate those directly in transact
#2971
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blockGasPriceEpic and actions were needed only because we had calling transactions spread across different parts of code. Now that we centralize tx calls in `transact`, we can move gasPrice[Factor] logic to it. This also optimizes not calling `getFeeData` on every block, and instead just when transactioning, with a local cache to ensure concurrent calls are deduplicated.
|
You modified |
Codecov Report
@@ Coverage Diff @@
## master #2971 +/- ##
==========================================
- Coverage 93.27% 93.26% -0.01%
==========================================
Files 207 207
Lines 8769 8747 -22
Branches 1357 1353 -4
==========================================
- Hits 8179 8158 -21
+ Misses 489 488 -1
Partials 101 101
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
This ensures txs in Raiden also use same gasPrice & gasLimit logic as epics.
andrevmatos
force-pushed
the
refactor/gasPrice
branch
from
3aa0af3
to
3f16c92
Compare
An optimization to avoid having to scan since genesis, when using `userDepositContractAddress` option instead of contracts info, and the user knows a blockNumber old enough to catch relevant events.
palango
approved these changes
Oct 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short description
technical debt tackling: since #2966 , all transactions go through
transactfunction/utility; therefore, we don't need to keepLatest.gasPrice(kept up to date every block through its own epic), since we only need to calculate thegasPriceon that function when making a transaciton; additionally,callAndWaitMinedhelper used in the publicRaidenclass had a lot of intersection withtransact's functionality, so it can be dropped for the later, allowing txs which are still directly in the public class to also benefit from the sharedgasPriceandgasLimitlogic there.This shouldn't change API or UX, so no need for a changelog entry.
Definition of Done
Steps to manually test the change (dApp)