Fix crash when starting client with UDC entrypoint on a TNR without registered tokens #2968
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2968 +/- ##
==========================================
- Coverage 93.27% 93.27% -0.01%
==========================================
Files 207 207
Lines 8770 8769 -1
Branches 1358 1357 -1
==========================================
- Hits 8180 8179 -1
Misses 489 489
Partials 101 101
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
If starting with userDepositContractAddress as contract's entrypoint, it'd crash if the `TokenNetworkRegistry` didn't have any registered `TokenNetwork`. This fix allows the client to start, so one can use `registerToken` to register a TN from this session.
andrevmatos
force-pushed
the
fix/no_registered_tn
branch
from
5b361aa
to
261ee27
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on top of #2967
Discovered in and closes #2913
Short description
Title
Definition of Done
Steps to manually test the change (dApp)