Support openChannelWithDeposit from new contracts #2919
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrevmatos
added
sdk 🖥
optimization ⚡
Codecov Report
@@ Coverage Diff @@
## master #2919 +/- ##
==========================================
+ Coverage 93.57% 93.66% +0.08%
==========================================
Files 116 116
Lines 6369 6394 +25
Branches 1149 1150 +1
==========================================
+ Hits 5960 5989 +29
+ Misses 354 350 -4
Partials 55 55
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
The later is simpler, receives saner parameters and includes more shared logic, like fetching balanceOf and allowance from token contract.
If channelOpen was requested with deposit and we're on the new contracts, instead of emitting a parallel channelDeposit.request with waitOpen=true, we ensureApprovedBalance$ inside channelOpenEpic and call `openChannelWithDeposit` directly, which should open and deposit in a single tx (faster); `channelEventsEpic` is able to handle deposits on the same block as open.
andrevmatos
force-pushed
the
feat/openChannelWithDeposit
branch
2 times, most recently
from
8622892
to
acac79e
Compare
andrevmatos
force-pushed
the
feat/openChannelWithDeposit
branch
from
acac79e
to
5883883
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2891
Short description
raiden-contracts 0.39 supports a new method:
openChannelWithDeposit, which does channel open + deposit in a single transaction, more efficient and faster to confirm than separate channelOpen + channelDeposit. This PR dynamically uses this method iff contracts being used support it, falling back to normalopen + confirmation + deposit + confirmationas a fallback (so we can still suport 0.37 and 0.39+ contracts on the same codebase).This is transparent, and automatically done when deposit is requested together with open, if possible.
A small edge case to keep in mind (and tested by SP, and now with tests specific for it) is when two peers try to
openChannelWithDepositwith each other at the same time; only one of the txs will succeed, making the "open" side of it to succeed for both clients but "deposit" only for the side which won the race; in this case, the losing side will detect it and fallback to emitting thechannelDeposit.requestas it was with the old mechanism, completing the deposit and succeeding theopen + depositoperation, as expected by the user.Definition of Done
Steps to manually test the change (dApp)