Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds automatic documentation generation #287

Merged
merged 1 commit into from
Aug 28, 2019
Merged

Adds automatic documentation generation #287

merged 1 commit into from
Aug 28, 2019

Conversation

kelsos
Copy link
Contributor

@kelsos kelsos commented Aug 27, 2019

Closes #84

@codecov
Copy link

codecov bot commented Aug 27, 2019

Codecov Report

Merging #287 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #287   +/-   ##
=======================================
  Coverage   97.34%   97.34%           
=======================================
  Files          39       39           
  Lines         715      715           
  Branches       63       63           
=======================================
  Hits          696      696           
  Misses         10       10           
  Partials        9        9
Flag Coverage Δ
#dapp 97.34% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dfe87e1...f878e99. Read the comment docs.

@codecov
Copy link

codecov bot commented Aug 27, 2019 •
edited
Loading

Codecov Report

Merging #287 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #287   +/-   ##
=======================================
  Coverage   97.34%   97.34%           
=======================================
  Files          39       39           
  Lines         715      715           
  Branches       63       63           
=======================================
  Hits          696      696           
  Misses         10       10           
  Partials        9        9
Flag Coverage Δ
#dapp 97.34% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dfe87e1...9fab59e. Read the comment docs.

nephix
nephix suggested changes Aug 28, 2019
View reviewed changes
Copy link
Contributor

@nephix nephix left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job!

The only thing is that we should somewhere in:

have a section called SDK API Docs that points developers to lightclient.raiden.network/docs

Probably makes sense to include it in this PR

@kelsos
Copy link
Contributor Author

kelsos commented Aug 28, 2019

I would prefer to ensure that the deployment works properly before modifying the documentation

@nephix
Copy link
Contributor

nephix commented Aug 28, 2019

I have created #292 for this. Feel free to merge

@kelsos kelsos merged commit 1704724 into raiden-network:master Aug 28, 2019
@kelsos kelsos deleted the documentation branch August 28, 2019 08:09
@kelsos
Copy link
Contributor Author

kelsos commented Aug 28, 2019

@nephix thanks :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nephix nephix nephix approved these changes

@andrevmatos andrevmatos Awaiting requested review from andrevmatos

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Have an automatically generated documentation
2 participants
@kelsos @nephix