Next #2822
Merged
Next #2822
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2822 +/- ##
==========================================
+ Coverage 93.51% 93.60% +0.08%
==========================================
Files 111 110 -1
Lines 6001 6036 +35
Branches 1086 1093 +7
==========================================
+ Hits 5612 5650 +38
+ Misses 335 331 -4
- Partials 54 55 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
andrevmatos
added
next
This removes completely the requirement to having access to peer's presence directly from the matrix server, and instead replace it with the requirement for the PFS to know (already required for mediated transfers) and provide that presence (implemented in `next` RSB). Instead of searchUserDirectory, we request the PFS `/address/.../metadata` endpoint for its view of latest peer's presence.
Now that presence is fetched from PFS, we don't need to join discovery global room anymore, and since PFS and MS rooms were removed previously, we can clear the utility and helpers which supported this.
Also fix some typos
and validate peer's displayname signature coming from service
Services now return a new `address_metadata` field which maps addresses to their respective metadata/presence object. We need to handle this, and pass it in a transfer's metadata. Besides this, mediated transfers should try to use this mapping in the incoming transfer's metadata to optimize not having to request metadata from service to send the output message. This usage, despite validated by signature, should be constrained to this transfer only (for now).
Processed, SecretRequest, SecretReveal and Unlock messages Also, don't use messageSend's userId on retries: If this message had to be retried, maybe the userId isn't valid anymore, so we remove it on retries, to force transport to re-fetch this peer's presence/metadata, or mind its own caching mechanism as needed.
So, PC mediators assume they're the 1st address in route, and their partner 2nd, and trim it when forwarding the transfer. We comply here until they can handle passing whole metadata unchanged.
PC signs metadata with checksummed addresses, but send them all lowercase-serialized. We were also decoding addresses checksummed, but `address_metadata`, being a dict, was being exempted from this change. This is just a workaround: proper fix is to perfectly sign what is received/sent (passthrough), and being able to handle receiving both.
This reverts commit 4198e17.
weilbith
approved these changes
Jun 16, 2021
There was a problem hiding this comment.
Basically everything has been already review by PRs targeting the next branch. I just took a quick look on the last commits. Looks all good to me. So I don't see a reason why we should not merge this to master. So the final testing before the mainnet release can start.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #
Short description
Definition of Done
Steps to manually test the change (dApp)