Feature/dapp switch eth balance according to account #2273
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The AccountContent view is displaying a single ETH balance. It gives no information from which account this balance is. Moreover does this balance depend on if the Raiden account has a balance or not. To improve this view and do not confuse the user there are two improvements. First should the balance not switch dependent on if there is a Raiden account balance or not, but rather when a Raiden account is in use or not. But actually it is more informative for the user to just show both balances. In case no Raiden account is used, the main account balance is sufficient.
The UDC screen in the account router shows an ETH balance during the withdrawal procedure. The relevant balance depends on if a Raiden account is used. So far it always shows the main account balance. This can be confusing, when the Raiden account has no balance, the transaction to withdrawal fails, but the UI displays a positive (and high enough) ETH balance. Therefore this balance must always relate to the correct account that is relevant for this transaction.
Codecov Report
@@ Coverage Diff @@
## master #2273 +/- ##
===========================================
+ Coverage 58.00% 94.79% +36.79%
===========================================
Files 61 156 +95
Lines 4460 6264 +1804
Branches 936 1160 +224
===========================================
+ Hits 2587 5938 +3351
+ Misses 1860 261 -1599
- Partials 13 65 +52
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
taleldayekh
approved these changes
Oct 19, 2020
|
We don't understand what CodeCov wants to tell us here. Looks pretty broken. The changed/added tests are pretty good. Therefore this gets merged now. |
weilbith
deleted the
feature/dapp-switch-eth-balance-according-to-account
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2224
Short description
In addition to the origin issue, I agreed with @taleldayekh that showing both ETH balances on the main account screen is another helpful addition for the user. This is ofc only the case if a Raiden account is in use.
Definition of Done
Steps to manually test the change (dApp)