Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename VUE_APP_TRANSPORT and support VUE_APP_MATRIX_LIST_URL envvar #2009

Merged
merged 1 commit into from
Jul 30, 2020

Conversation

andrevmatos
Copy link
Contributor

@andrevmatos andrevmatos commented Jul 30, 2020

Fixes #2002

Short description

  • Rename VUE_APP_TRANSPORT to VUE_APP_MATRIX_SERVER to avoid conflict with previous var
  • Add VUE_APP_MATRIX_LIST_URL:
    • passed to SDK's matrixServerLookup config
    • Has less priority than VUE_APP_MATRIX_SERVER, so make sure that's unset if one wants to iterate over the list in case of the first server isn't responding properly
    • Should be set to a URL ofa file containing a yaml-like list of servers, e.g.: https://raw.githubusercontent.com/raiden-network/raiden-service-bundle/master/known_servers.main.yaml

Definition of Done

  • Steps to manually test the change have been documented
  • Acceptance criteria are met
  • Change has been manually tested by the reviewer (dApp)

Steps to manually test the change (dApp)

@andrevmatos andrevmatos self-assigned this Jul 30, 2020
@andrevmatos andrevmatos changed the title Rename VUE_APP_TRANSPORT and support VUE_APP_MATRIX_LIST_URL envar Rename VUE_APP_TRANSPORT and support VUE_APP_MATRIX_LIST_URL envvar Jul 30, 2020
@andrevmatos
Copy link
Contributor Author

@agatsoh this should allow you to set the mainnet's known_server's list URL, and the client will sort them by response times for you, and also try next if one server is failing or not CORS-enabled.
Make sure to unset the previous transport var (not only set it to empty)

Copy link
Contributor

@taleldayekh taleldayekh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Go for it!

@codecov
Copy link

codecov bot commented Jul 30, 2020

Codecov Report

Merging #2009 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2009   +/-   ##
=======================================
  Coverage   95.78%   95.78%           
=======================================
  Files         154      154           
  Lines        5831     5831           
  Branches     1105     1105           
=======================================
  Hits         5585     5585           
  Misses        186      186           
  Partials       60       60           
Flag Coverage Δ
#dapp 92.55% <ø> (ø)
#sdk 97.08% <ø> (ø)
#sdk_e2e 65.89% <ø> (-0.13%) ⬇️
#sdk_unit 85.93% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
raiden-dapp/src/services/raiden-service.ts 88.88% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 70717a1...89c61c8. Read the comment docs.

@andrevmatos andrevmatos merged commit b51b2a3 into master Jul 30, 2020
@andrevmatos andrevmatos deleted the feature/dapp_matrix_list branch July 30, 2020 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CORS error for light client on all transport servers on mainnet
2 participants