Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes scrollbar displaying in channels screen without many items #1502

Merged
merged 2 commits into from
May 13, 2020
Merged

Fixes scrollbar displaying in channels screen without many items #1502

merged 2 commits into from
May 13, 2020

Conversation

kelsos
Copy link
Contributor

@kelsos kelsos commented May 12, 2020

Fixes #1490

Short description
Makes sure that scrollbar is not shown unless there are enough items to need a scrollbar

Definition of Done

  • Steps to manually test the change have been documented
  • Acceptance criteria are met
  • Change has been manually tested by the reviewer (dApp)

Steps to manually test the change (dApp)

  1. Go to channels.
  2. If you have one or two channels, no scrollbar should display.

@kelsos kelsos changed the title Light client 1490 Fixes scrollbar displaying in channels screen without many items May 12, 2020
@codecov
Copy link

codecov bot commented May 12, 2020

Codecov Report

Merging #1502 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1502   +/-   ##
=======================================
  Coverage   96.06%   96.06%           
=======================================
  Files         140      140           
  Lines        5000     5000           
  Branches      927      984   +57     
=======================================
  Hits         4803     4803           
  Misses        153      153           
  Partials       44       44           
Flag Coverage Δ
#dapp 91.93% <ø> (ø)
#sdk 97.64% <ø> (ø)
Impacted Files Coverage Δ
raiden-dapp/src/components/navigation/Channels.vue 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7ffe343...ae43b57. Read the comment docs.

@nephix
Copy link
Contributor

nephix commented May 13, 2020

@kelsos with how many channels have you tested this because there was a bug #1427

@kelsos
Copy link
Contributor Author

kelsos commented May 13, 2020

I had to open 3 channels otherwise the scrollbar would not appear, but there is an empty space following the last expanded area so we should still be safe.

@@ -11,6 +11,7 @@

### Fixed

- [#1490] Fixes scrollbar always showing up in channels screen.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only need to update change log I guess

@kelsos kelsos merged commit cd9f253 into raiden-network:master May 13, 2020
@kelsos kelsos deleted the light-client-1490 branch May 13, 2020 11:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Scroll bar if no scroll bar is needed on the channel screen
2 participants