Fix per channel event monitoring and past events fetching #1475
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1434
Short description
Refactors the channel monitoring logic, which became more complex than it should. With little logs to investigate, and after some real life observation of some events being lost in very specific cases, this became the main target for thsi issue.
I did test by opening ~9 channels with hub, and this issue was not experienced.
Definition of Done
Steps to manually test the change (dApp)
{ settleTimeout: 60 }
(passed directly toRaiden.openChannel
method), which is a huge improvement on waiting time over default=500.