Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed scroll bar issue in channel list #1440

Merged
merged 1 commit into from
Apr 29, 2020

Conversation

nephix
Copy link
Contributor

@nephix nephix commented Apr 29, 2020

Thank you for submitting this pull request :)

Fixes #1427

Short description

There's currently another scroll bar issue that is not related to this one: #1439

Definition of Done

  • Steps to manually test the change have been documented
  • Acceptance criteria are met
  • Change has been manually tested by the reviewer (dApp)

Steps to manually test the change (dApp)

No steps neccessary, here are GC & FF screenshots:

Screenshot 2020-04-29 at 11 28 34

Screenshot 2020-04-29 at 11 27 51

@nephix nephix marked this pull request as draft April 29, 2020 09:40
@codecov
Copy link

codecov bot commented Apr 29, 2020

Codecov Report

Merging #1440 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1440   +/-   ##
=======================================
  Coverage   96.10%   96.10%           
=======================================
  Files         129      129           
  Lines        4801     4801           
  Branches      999      999           
=======================================
  Hits         4614     4614           
  Misses        139      139           
  Partials       48       48           
Flag Coverage Δ
#dapp 91.58% <ø> (ø)
#sdk 97.79% <ø> (ø)
Impacted Files Coverage Δ
raiden-dapp/src/components/navigation/Channels.vue 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 464b899...09163ba. Read the comment docs.

@nephix nephix force-pushed the fix/scroll-bar-channel-list branch from f7ccff0 to 09163ba Compare April 29, 2020 10:18
@nephix nephix marked this pull request as ready for review April 29, 2020 10:18
Copy link
Contributor

@kelsos kelsos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgmt thanks

@nephix nephix merged commit 7a339d9 into raiden-network:master Apr 29, 2020
@nephix nephix deleted the fix/scroll-bar-channel-list branch April 29, 2020 10:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Last channel is partially hidden when there's many channels
2 participants