Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for displayed service fee in summary #1095

Merged
merged 5 commits into from
Feb 27, 2020

Conversation

nephix
Copy link
Contributor

@nephix nephix commented Feb 27, 2020

@@ -525,37 +525,6 @@ export default class TransferSteps extends Mixins(
<style lang="scss" scoped>
@import '../scss/colors';

.confirmation-overlay {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not related, just removed it because it's not used

@codecov
Copy link

codecov bot commented Feb 27, 2020

Codecov Report

Merging #1095 into master will not change coverage by %.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1095   +/-   ##
=======================================
  Coverage   96.16%   96.16%           
=======================================
  Files         110      110           
  Lines        3883     3883           
  Branches      797      797           
=======================================
  Hits         3734     3734           
  Misses        104      104           
  Partials       45       45           
Flag Coverage Δ
#dapp 91.89% <ø> (ø) ⬆️
#sdk 97.81% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8c011d7...29f654c. Read the comment docs.

Copy link
Contributor

@taleldayekh taleldayekh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As far as I understand it looks perfectly good, Danke schön. :) :)

@nephix nephix merged commit 9b9859c into raiden-network:master Feb 27, 2020
@nephix nephix deleted the fix/direct-transfer-service-fee branch February 27, 2020 09:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants