Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lower transfer expiration for dApp #2409

Closed
4 tasks done
palango opened this issue Nov 26, 2020 · 2 comments · Fixed by #2436
Closed
4 tasks done

Lower transfer expiration for dApp #2409

palango opened this issue Nov 26, 2020 · 2 comments · Fixed by #2436
Assignees
Labels
cli 🔤 Command-line SDK-based Node.js Client issues dApp 📱 Ready 🎬 Issues which are ready to be pulled into the iteration sdk 🖥

Comments

@palango
Copy link
Contributor

palango commented Nov 26, 2020

In https://github.com/raiden-network/team/issues/894 and https://github.com/raiden-network/team/issues/891 we made the case for a shorter time between receiving a secret and the on-chain transaction in case we don't receive an unlock.

A decision has been made, and we need to implement it for the dApp (and possibly the CLI).

  • SDK
    • Make lock expiration configurable
    • Add test for the minimal expiration
  • dApp
    • Use lower expiration by default
  • CLI
    • Decide if lower expirations should be used
@palango palango added this to the Product Backlog milestone Nov 26, 2020
@palango palango added cli 🔤 Command-line SDK-based Node.js Client issues dApp 📱 sdk 🖥 labels Dec 3, 2020
@palango palango modified the milestone: Product Backlog Dec 3, 2020
@palango palango self-assigned this Dec 3, 2020
@taleldayekh

This comment has been minimized.

@taleldayekh taleldayekh added the Ready 🎬 Issues which are ready to be pulled into the iteration label Dec 4, 2020
@palango palango mentioned this issue Dec 7, 2020
3 tasks
@palango palango removed this from the Product Backlog milestone Dec 9, 2020
@palango
Copy link
Contributor Author

palango commented Dec 9, 2020

I read the code and tested it manually: The PC accepts mediations up until the reveal timeout, so no action on the python side is necessary.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cli 🔤 Command-line SDK-based Node.js Client issues dApp 📱 Ready 🎬 Issues which are ready to be pulled into the iteration sdk 🖥
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants