test: cleaning up deprecated usages #23
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
athakor
reviewed
Jan 23, 2020
|
|
||
| @Test | ||
| @Test(expected = IllegalArgumentException.class) |
There was a problem hiding this comment.
You can't simply remove these. They need to be replaced with a try-catch block and a fail.
There was a problem hiding this comment.
Thanks for pointing it out, PTAL
athakor
reviewed
Jan 23, 2020
| @@ -81,16 +77,14 @@ public void testWithTransportChannel() { | |||
| Truth.assertThat(context.getChannel()).isSameInstanceAs(channel); | |||
| } | |||
|
|
|||
| @Test | |||
| @Test(expected = IllegalArgumentException.class) | |||
athakor
approved these changes
Jan 23, 2020
rahulKQL
force-pushed
the
test_deprecation
branch
from
7694668 to
9489a08
Compare
removed deprecated `ExpectedException.none()` usage across unit test cases. chore: address feedback comments
rahulKQL
force-pushed
the
test_deprecation
branch
from
9489a08 to
bb4a7b7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
removed deprecated
ExpectedException.none()usage across unit test cases.