Some Improvement #49
Some Improvement #49
Conversation
b0c1
commented
Jan 31, 2023
b0c1
commented
- Add commit handler to format all documents when push
- Add editor context menu to format current file
- Add VCS change list context menu to format multiple files
- [x] Added Reformat multiple files in VCS context menu - [x] Add editor context menu
|
Thanks for the contribution @b0c1, I'll review in the next couple of days. Would you mind posting some screenshots of any UI changes for future reference? Also, I just added |
| PsiManager manager = PsiManager.getInstance(project); | ||
| Stream | ||
| .concat(getExactlySelectedFiles(manager, event).stream(), selectedChangesetFiles(manager, event).stream()) | ||
| .forEach(file -> new ReformatCodeProcessor(file, false).run()); |
There was a problem hiding this comment.
Unfortunately, this does not work since we can only run one gradle process at a time on a project. If you try to run this with multiple files, you will see an error such as:
.
This is the same issue that #33 ran into. In order for this to be fixed and for me to accept this change, we'll need to implement or push for some progress on diffplug/spotless#791.
Another alternative is to switch over to using IntelliJ's External Formatter API which I attempt to do in this branch, but this would drastically change the UX of the plugin, and I was running into some multithreading issues :(
