Image grayscale processor #6
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for working on this! This is a good start. This works for setting up a route to grayscale images by default, but I think we'd also like to allow this via the URL api as well. So we should add this as a member on I also wonder if there should be a way to enable/disable the feature in the configuration in addition to setting a default. |
|
@mzsanford The image processing API has undergone some refactoring in master. The statsd changes you made are already in master. If you refactor on top of master your PR should end up very small and easy to merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Noticed a note on the blog post suggesting it. There are several different ways to go about it but this seemed like the simplest and it required the least complex configuration.