Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

runAsPopoverForView:preferredEdge:withCompletionBlock: ignores input preferredEdge #6

Open
funnel20 opened this issue Jul 16, 2022 · 1 comment
Open

runAsPopoverForView:preferredEdge:withCompletionBlock: ignores input preferredEdge #6

funnel20 opened this issue Jul 16, 2022 · 1 comment

Comments

@funnel20
Copy link

funnel20 commented Jul 16, 2022 •
edited
Loading

Variable preferredEdge is not used in runAsPopoverForView:preferredEdge:withCompletionBlock:, since it calls showRelativeToRect:ofView:preferredEdge: with hardcoded value NSMaxYEdge:

NSAlert-Popover/NSAlert+Popover.m

Line 60 in 3b2b425

[popover showRelativeToRect:view.bounds ofView:view preferredEdge:NSMaxYEdge];

This line should be changed to use input parameterpreferredEdge as input:

[popover showRelativeToRect:view.bounds ofView:view preferredEdge:preferredEdge];
funnel20 added a commit to funnel20/NSAlert-Popover that referenced this issue Jul 16, 2022
@funnel20
Resolved issue raffael#6
65eba71 
Actually use input parameter `preferredEdge` in method `runAsPopoverForView:preferredEdge:withCompletionBlock:` by replacing the hardcoded value `NSMaxYEdge`.
@funnel20
Copy link
Author

funnel20 commented Jul 16, 2022 •
edited
Loading

This has been resolved in commit 12 of my fork.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@funnel20