Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add get_scale definition to GRIBDatasetsExt #802

Merged
merged 1 commit into from
Dec 8, 2024
Merged

Conversation

asinghvi17
Copy link
Collaborator

Same as for ZarrDatasetsExt. Needs a test with a grib file.

Same as for ZarrDatasetsExt.
@asinghvi17
Copy link
Collaborator Author

all the segfaults from GDAL, lol...

@rafaqz
Copy link
Owner

rafaqz commented Oct 14, 2024

Aah it's GDAL warp segfaulting I was hoping it would just go away

@visr do you have an idea what's going on there? Has anything obvious changed in the GDAL side?

@visr
Copy link

visr commented Oct 14, 2024

Hmm strange. The GDAL build was broken last week: JuliaGeo/GDAL.jl#179
So two new builds were released: https://github.com/JuliaBinaryWrappers/GDAL_jll.jl/releases
It looks like you are on the latest release. Can you easily try 301.901.201? Then we could narrow it down. The GDAL 3.9.3 release that came out today also lists two gdalwarp improvements, though this looks more like a regression: https://github.com/OSGeo/gdal/blob/v3.9.3/NEWS.md

We should also fix the Rasters.jl GDAL.jl integration tests again. I haven't looked at them much since they've been red since the beginning.

@visr
Copy link

visr commented Oct 15, 2024

So it seems from #806 that GDAL_jll v301.901.201 works ok but v301.902.200 segfaults on gdalwarp, but otherwise seems functional?

@rafaqz
Copy link
Owner

rafaqz commented Oct 15, 2024

Yeah, all the other GDAL tests are passing.

@visr
Copy link

visr commented Oct 16, 2024

Might be a GDAL issue then, not a build failure. Though you could still try the latest GDAL patch release that came out today in the GDAL_jll. Not sure which of the gdalwarp tests is segfaulting. GDAL.jl does have a basic gdalwarp test as well, not as many variations as Rasters.jl though.

@asinghvi17 asinghvi17 closed this Oct 23, 2024
@asinghvi17 asinghvi17 reopened this Oct 23, 2024
@rafaqz rafaqz closed this Dec 1, 2024
@rafaqz rafaqz reopened this Dec 1, 2024
@rafaqz
Copy link
Owner

rafaqz commented Dec 1, 2024

Was there a test for this?

@rafaqz rafaqz merged commit 91cf3b5 into cf Dec 8, 2024
2 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants