Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Respect axis = (; type = ...) when type is a LScene #855

Merged
merged 4 commits into from
Nov 12, 2024
Merged

Conversation

asinghvi17
Copy link
Collaborator

Previously not respected. See test for example.

@rafaqz
Copy link
Owner

rafaqz commented Nov 12, 2024

Just needs Makie.LScene

@rafaqz
Copy link
Owner

rafaqz commented Nov 12, 2024

You can ignore the docs failures, but somehow there is still an LScene error

@asinghvi17
Copy link
Collaborator Author

asinghvi17 commented Nov 12, 2024

Should be fixed now, that was an omission in the tests :)

Copy link

codecov bot commented Nov 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.71%. Comparing base (3dfdcee) to head (f4a1430).
Report is 6 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #855      +/-   ##
==========================================
+ Coverage   83.38%   83.71%   +0.32%     
==========================================
  Files          46       47       +1     
  Lines        4634     4635       +1     
==========================================
+ Hits         3864     3880      +16     
+ Misses        770      755      -15     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rafaqz rafaqz merged commit f4d73f3 into main Nov 12, 2024
8 of 10 checks passed
@rafaqz rafaqz deleted the as/respect_type branch November 12, 2024 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants