Skip to content

Commit

Permalink
chore(): add guide for code reviews
Browse files Browse the repository at this point in the history
  • Loading branch information
jelbourn committed Jan 5, 2016
1 parent e22c978 commit d4db0f4
Showing 1 changed file with 17 additions and 0 deletions.
17 changes: 17 additions & 0 deletions CODE_REVIEWS.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,17 @@
# Code reviews for Angular Material

* Before any coding begins on new, large, or breaking work, a design discussion should take place.
* All code changes require a review and approval.
* All behaviors should be covered by unit tests in the same PR.
* Large changes should be accompanied by corresponding e2e tests in the same PR.
* Authors should attempt to keep PRs to 200 - 300 line changes.

## Workflow
1. The code author sends a PR for review. This request should include:
* A mention of the intended reviewer(s) (e.g., `@jelbourn`)
* A high-level description of the change being made.
* Links to any relevant issues.
* Screenshots (for visual changes or new additions)
2. Reviews provide comments and the author responds / makes changes. Repeat until LGTM.
3. One or more of the reviewers applies the "LGTM" label.
4. The party responsible for merging PRs will do so.

0 comments on commit d4db0f4

Please sign in to comment.