remove md5 #15
Comments
|
Looks fine for me. I probably added it originally for utilities purposes, but if it's not used anywhere in the project, it's ok to remove. By the way, the time I wrote libcgi I was using php for web programming, and I wanted to have some of the facilities in C as well, so that's why there are some functions like |
|
I noticed those functions, but this is topic for another ticket. I came across the md5 stuff because I'm reviewing the autoconf/automake stuff and this can be removed from configure and makefile then. |
|
I agree that there's no reason to provide MD5 as part of this library. |
LeSpocky
added a commit
to LeSpocky/libcgi
that referenced
this issue
Jul 13, 2018
Quote from issue rafaelsteil#15: > libcgi contains an implementation of the md5 hash function, however > its not used inside the library itself and the status regarding > license or potential security issues (despite the weekness of md5 > itself) is not clear. If a user needs md5 he or she could get it from > a specialized library. Although md5 is deprecated (rafaelsteil#15) we can not simply remove the code from the API. Do that later. The HAVE_MD5 macro is useless, that was a relict from the old autotools build and actually meant »build with md5«, so we can simply drop the build time generated file and that macro. Fixes: 0643151 Signed-off-by: Alexander Dahl <[email protected]>
LeSpocky
added a commit
to LeSpocky/libcgi
that referenced
this issue
Jul 16, 2018
Quote from issue rafaelsteil#15: > libcgi contains an implementation of the md5 hash function, however > its not used inside the library itself and the status regarding > license or potential security issues (despite the weekness of md5 > itself) is not clear. If a user needs md5 he or she could get it from > a specialized library. Although md5 is deprecated (rafaelsteil#15) we can not simply remove the code from the API. Do that later. The HAVE_MD5 macro is useless, that was a relict from the old autotools build and actually meant »build with md5«, so we can simply drop the build time generated file and that macro. Fixes: 0643151 Signed-off-by: Alexander Dahl <[email protected]>
LeSpocky
added a commit
to LeSpocky/libcgi
that referenced
this issue
Jul 16, 2018
Quote from issue rafaelsteil#15: > libcgi contains an implementation of the md5 hash function, however > its not used inside the library itself and the status regarding > license or potential security issues (despite the weekness of md5 > itself) is not clear. If a user needs md5 he or she could get it from > a specialized library. Although md5 is deprecated (rafaelsteil#15) we can not simply remove the code from the API. Do that later. The HAVE_MD5 macro is useless, that was a relict from the old autotools build and actually meant »build with md5«, so we can simply drop the build time generated file and that macro. Fixes: 0643151 Signed-off-by: Alexander Dahl <[email protected]>
LeSpocky
added a commit
to LeSpocky/libcgi
that referenced
this issue
Jul 19, 2018
Quote from issue rafaelsteil#15: > libcgi contains an implementation of the md5 hash function, however > its not used inside the library itself and the status regarding > license or potential security issues (despite the weekness of md5 > itself) is not clear. If a user needs md5 he or she could get it from > a specialized library. Although md5 is deprecated (rafaelsteil#15) we can not simply remove the code from the API. Do that later. The HAVE_MD5 macro is useless, that was a relict from the old autotools build and actually meant »build with md5«, so we can simply drop the build time generated file and that macro. Fixes: 0643151 Signed-off-by: Alexander Dahl <[email protected]>
LeSpocky
added a commit
to LeSpocky/libcgi
that referenced
this issue
Nov 12, 2018
This is a first step to make libcgi compliant to the REUSE initiative: https://reuse.software/ We do this here before adding new files to the project. Note: this is not complete, especially the following parts will take additional attention: * `test/trim.c` is in the public domain, SPDX has no identifier for that and it is not clear how to handle such situations. * It is not clear where `src/md5.c` comes from, but it's deprecated anyway, so it will be removed in the future, circumventing any licensing problems with it. Also see rafaelsteil#15 for that. * There is no license applied to any code in the 'examples' folder, yet.
LeSpocky
added a commit
to LeSpocky/libcgi
that referenced
this issue
Nov 12, 2018
This is a first step to make libcgi compliant to the REUSE initiative: https://reuse.software/ We do this here before adding new files to the project, working towards a consistent style in file headers. Note: this is not complete, especially the following parts will take additional attention: * `test/trim.c` is in the public domain, SPDX has no identifier for that and it is not clear how to handle such situations. * It is not clear where `src/md5.c` comes from, but it's deprecated anyway, so it will be removed in the future, circumventing any licensing problems with it. Also see rafaelsteil#15 for that. * There is no license applied to any code in the 'examples' folder, yet.
|
What's the state of this issue? There is still MD5 related code inside the repository. Can it just be removed? |
|
The md5 related code was marked deprecated with b4a284c and will be removed with API v2. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
libcgi contains an implementation of the md5 hash function, however its not used inside the library itself and the status regarding license or potential security issues (despite the weekness of md5 itself) is not clear. If a user needs md5 he or she could get it from a specialized library.
(Comments welcome.)
The text was updated successfully, but these errors were encountered: