Skip to content

Commit

Permalink
refactor: Re-arrange Driver tests
Browse files Browse the repository at this point in the history
Change ApplyMigration to be subtests instead of table-driven tests
because it's easier to target specific tests with the "-run" flag rather
find the nth test that didn't work. There's like 20 tests.
  • Loading branch information
rafaelespinoza committed May 8, 2021
1 parent 71372d0 commit 9196510
Show file tree
Hide file tree
Showing 9 changed files with 924 additions and 871 deletions.
4 changes: 2 additions & 2 deletions drivers/mysql/mysql_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -4,9 +4,9 @@ import (
"testing"

"github.com/rafaelespinoza/godfish/drivers/mysql"
"github.com/rafaelespinoza/godfish/internal"
"github.com/rafaelespinoza/godfish/internal/test"
)

func Test(t *testing.T) {
internal.RunDriverTests(t, mysql.NewDriver())
test.RunDriverTests(t, mysql.NewDriver())
}
4 changes: 2 additions & 2 deletions drivers/postgres/postgres_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -4,9 +4,9 @@ import (
"testing"

"github.com/rafaelespinoza/godfish/drivers/postgres"
"github.com/rafaelespinoza/godfish/internal"
"github.com/rafaelespinoza/godfish/internal/test"
)

func Test(t *testing.T) {
internal.RunDriverTests(t, postgres.NewDriver())
test.RunDriverTests(t, postgres.NewDriver())
}
4 changes: 2 additions & 2 deletions drivers/sqlite3/sqlite3_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -4,9 +4,9 @@ import (
"testing"

"github.com/rafaelespinoza/godfish/drivers/sqlite3"
"github.com/rafaelespinoza/godfish/internal"
"github.com/rafaelespinoza/godfish/internal/test"
)

func Test(t *testing.T) {
internal.RunDriverTests(t, sqlite3.NewDriver())
test.RunDriverTests(t, sqlite3.NewDriver())
}
5 changes: 2 additions & 3 deletions internal/stub/driver_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -3,11 +3,10 @@ package stub_test
import (
"testing"

"github.com/rafaelespinoza/godfish/internal"
"github.com/rafaelespinoza/godfish/internal/stub"
"github.com/rafaelespinoza/godfish/internal/test"
)

func Test(t *testing.T) {
var driver stub.Driver
internal.RunDriverTests(t, &driver)
test.RunDriverTests(t, &stub.Driver{})
}
Loading

0 comments on commit 9196510

Please sign in to comment.