Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[feature] Add invalid state #67

Closed
TCeason opened this issue Jul 1, 2019 · 3 comments
Closed

[feature] Add invalid state #67

TCeason opened this issue Jul 1, 2019 · 3 comments
Assignees
@BohuTANG @TCeason
Labels
P0 High priority type: feature
Milestone
v1.0.7

Comments

@TCeason
Copy link
Contributor

TCeason commented Jul 1, 2019

Summary

MySQL ueses Engine commit（If MySQL trx prepare and flush to data, it will be committed. ） to protect data security. But it may not be suite for MySQL Cluster.

Fix

  1. Add invalid state （Invalid should not send a agree vote）
  2. If check Engine commit , set the node status to invalid（use gtid_sub function, so we also need check gtid when raft election）

Question

  1. If xenon dead, the state may be confusion, so we should record all state into a file.
@TCeason TCeason added the P0 High priority label Jul 1, 2019
@TCeason TCeason self-assigned this Jul 1, 2019
@BohuTANG
Copy link
Contributor

BohuTANG commented Jul 1, 2019

ACK

@BohuTANG BohuTANG self-assigned this Jul 1, 2019
@BohuTANG BohuTANG added this to the v1.0.7 milestone Jul 1, 2019
@TCeason
Copy link
Contributor Author

TCeason commented Jul 1, 2019

ADD:

The Invalid state should not return ok to CANDICATEs , may be return ErrorInvalidRequest (or ErrorInvalidGtid)?

@BohuTANG

@BohuTANG
Copy link
Contributor

BohuTANG commented Jul 1, 2019

ACK

TCeason added a commit to TCeason/xenon that referenced this issue Jul 11, 2019
@TCeason
raft:Add INVALID state, modify raft radondb#67
a56b7f0
TCeason added a commit to TCeason/xenon that referenced this issue Jul 12, 2019
@TCeason
raft:Add INVALID state, modify raft radondb#67
cd4ba73
@TCeason TCeason mentioned this issue Jul 14, 2019
Merged
TCeason added a commit to TCeason/xenon that referenced this issue Jul 15, 2019
@TCeason
raft:Add INVALID state, modify raft radondb#67
83766aa
BohuTANG pushed a commit that referenced this issue Jul 15, 2019
@TCeason @BohuTANG
raft:Add INVALID state, modify raft #67
df24ca0
@TCeason TCeason closed this as completed Jul 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@BohuTANG BohuTANG

@TCeason TCeason

Labels
P0 High priority type: feature
Projects
None yet
Milestone
v1.0.7
Development

No branches or pull requests
2 participants
@BohuTANG @TCeason