api: add mysqltemplate webhook check #722 #724
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
acekingke
force-pushed
the
FixTemplWebhook
branch
from
5503628 to
8a61496
Compare
zhl003
approved these changes
Nov 1, 2022
| @@ -11,11 +11,9 @@ spec: | |||
|
|
|||
| # if you want create mysqlcluster from S3, uncomment and fill the directory in S3 bucket below: | |||
| # restoreFrom: | |||
| BackupSchedule: "0 50 * * * *" | |||
| backupSchedule: "0 50 * * * *" | |||
| mysqlOpts: | |||
| image: percona/percona-server:5.7.34 | |||
There was a problem hiding this comment.
Get the name of the image directly from the CR
There was a problem hiding this comment.
it is a mysql cluster cr， backup cr image can fit nothing，because it has default value
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/bug
Which issue(s) this PR fixes?
Fixes #722
What this PR does?
Summary:
add webhook and check the configmap of template exist.
Special notes for your reviewer?