Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: update go version to 1.17 #677

Merged
merged 1 commit into from
Aug 26, 2022
Merged

Conversation

runkecheng
Copy link
Collaborator

@runkecheng runkecheng commented Aug 25, 2022

What type of PR is this?

/enhancement

Which issue(s) this PR fixes?

go 1.16 -> 1.17.13

controller-util: v0.3.0 -> v0.4.3
corev1.Handler -> corev1.ProbeHandler, corev1.LifecycleHandler

BREAKING POINTS: CI

fix: #674

What this PR does?

Summary:

Special notes for your reviewer?

@runkecheng runkecheng added the enhancement New feature or request label Aug 25, 2022
@runkecheng runkecheng added this to the v2.3.0 milestone Aug 25, 2022
@runkecheng runkecheng requested review from acekingke and zhl003 August 25, 2022 08:14
@runkecheng runkecheng self-assigned this Aug 25, 2022
@runkecheng runkecheng changed the title feat(chore): update go version to 1.17 *: update go version to 1.17 Aug 25, 2022
go 1.16 -> 1.17.13

controller-util: v0.3.0 -> v0.4.3
corev1.Handler -> corev1.ProbeHandler, corev1.LifecycleHandler

BREAKING POINTS: CI

fix: radondb#674
Copy link
Collaborator

@zhl003 zhl003 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@acekingke acekingke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zhl003 zhl003 marked this pull request as ready for review August 26, 2022 07:11
@zhl003 zhl003 merged commit a328257 into radondb:main Aug 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[feature] update go version to 1.17
3 participants