Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

xenon: add preStop timeout #612

Merged
merged 1 commit into from
Jul 22, 2022
Merged

Conversation

zhl003
Copy link
Collaborator

@zhl003 zhl003 commented Jul 21, 2022

What type of PR is this?

Which issue(s) this PR fixes?

Fixes #

What this PR does?

Summary:

Special notes for your reviewer?

@zhl003 zhl003 requested review from runkecheng and acekingke and removed request for runkecheng July 21, 2022 06:25
@zhl003 zhl003 self-assigned this Jul 21, 2022
@zhl003 zhl003 force-pushed the prestop_xenon_kill branch 3 times, most recently from f55e13d to 1992db2 Compare July 21, 2022 08:28
@zhl003 zhl003 requested a review from runkecheng July 22, 2022 02:50
Dockerfile Outdated Show resolved Hide resolved
cmd/xenon/main.go Outdated Show resolved Hide resolved
@runkecheng
Copy link
Collaborator

Need to add an empty line between functions

@zhl003 zhl003 force-pushed the prestop_xenon_kill branch from 1992db2 to 01a87cc Compare July 22, 2022 03:57
@zhl003 zhl003 requested a review from acekingke July 22, 2022 04:02
Copy link
Contributor

@acekingke acekingke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@runkecheng runkecheng merged commit 5a471c8 into radondb:main Jul 22, 2022
zhl003 added a commit to zhl003/radondb-mysql-kubernetes that referenced this pull request Aug 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants